Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version of dark-mode #15

Closed
wants to merge 7 commits into from
Closed

Initial version of dark-mode #15

wants to merge 7 commits into from

Conversation

Pavangbhat
Copy link

@Pavangbhat Pavangbhat commented Oct 12, 2021 •
edited
Loading

closes #13

dark-goals-2021-10-11_21.29.43.mp4

@Pavangbhat Pavangbhat requested a review from RohitKuwar October 12, 2021 04:03
@Pavangbhat Pavangbhat self-assigned this Oct 12, 2021
@RohitKuwar
Copy link
Contributor

@Pavangbhat The icon is not centered vertically. Can we please make it centered?

@RohitKuwar
Copy link
Contributor

Screenshot (967)
@Pavangbhat Can we please fix this issue for mobile devices?

RohitKuwar
RohitKuwar reviewed Oct 12, 2021
View reviewed changes
Copy link
Contributor

@RohitKuwar RohitKuwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pavangbhat Overall work is good. Well done.

@Pavangbhat
Copy link
Author

@Pavangbhat Can we please have a border around the box/container?
Screenshot (968)

Sure

@Pavangbhat
Copy link
Author

Screenshot (967)
@Pavangbhat Can we please fix this issue for mobile devices?

Waiting for designs 😁

@Real-Dev-Squad Real-Dev-Squad deleted a comment from RohitKuwar Oct 13, 2021
@Pavangbhat
Copy link
Author

@Pavangbhat The icon is not centered vertically. Can we please make it centered?

Sure, here goal was to place a working icon

Pavangbhat
Pavangbhat commented Nov 1, 2021
View reviewed changes
Copy link
Author

@Pavangbhat Pavangbhat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neon borders 👇

image

harshith-venkatesh
harshith-venkatesh reviewed Nov 2, 2021
View reviewed changes
Copy link

@harshith-venkatesh harshith-venkatesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Pavan

akshay1502
akshay1502 reviewed Nov 3, 2021
View reviewed changes
@RohitKuwar
Copy link
Contributor

@Pavangbhat Can we please fix the dark-mode icon place for the mobile devices?

Screenshot (986)

@RohitKuwar
Copy link
Contributor

@Pavangbhat If possible, can we please add a little transition while the theme is changing?

@RohitKuwar
Copy link
Contributor

@Pavangbhat Can we please place the dark-theme icon at the extreme right side of the navbar?

Screenshot (987)

like this:
Screenshot (988)

@Pavangbhat
Copy link
Author

@Pavangbhat If possible, can we please add a little transition while the theme is changing?

Sure 💯

Pavangbhat
Pavangbhat commented Nov 10, 2021
View reviewed changes
Copy link
Author

@Pavangbhat Pavangbhat left a comment •
edited by Kshashank99
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • responsive design
  • transition effect on theme change
goal_dark-2021-11-10_12.33.22.mp4

@Pavangbhat Pavangbhat added the feature task A big ticket item that needs to come up as a feature label Nov 10, 2021
RohitKuwar
RohitKuwar reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@RohitKuwar RohitKuwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Pavangbhat !!!

@pallabez pallabez closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshith-venkatesh harshith-venkatesh harshith-venkatesh left review comments

@akshay1502 akshay1502 akshay1502 left review comments

@RohitKuwar RohitKuwar RohitKuwar left review comments

Assignees

@Pavangbhat Pavangbhat

Labels
feature task A big ticket item that needs to come up as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark mode for goals site
5 participants
@Pavangbhat @RohitKuwar @harshith-venkatesh @akshay1502 @pallabez