Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backups don't run if using full container name. #71

Open
DelusionalAI opened this issue Jun 30, 2024 · 2 comments
Open

Backups don't run if using full container name. #71

DelusionalAI opened this issue Jun 30, 2024 · 2 comments

Comments

@DelusionalAI
Copy link

I've been using Podman in place of Docker, but Podman requires the full container location, i.e. docker.io/library/postgres, instead of the short form Postgres or even library/postgres.

When running the python script, the name of the container returns as ['docker.io/library/postgres'] instead of ['postgres'], this cases get_backup_provider to return none instead of the Postgres provider.

I was able to get it working locally by changing patterns=["postgres", "tensorchord/pgvecto-rs", "nextcloud/aio-postgresql"] to patterns=["*postgres", "tensorchord/pgvecto-rs", "nextcloud/aio-postgresql"] but I imagine something would need to be changed for SQL as well, and while it works for me I'm not sure if there are other containers that would cause an issue with.

@DelusionalAI
Copy link
Author

This still didn't quite fix it for my use case. The container name now comes across as {'library/postgres'} for my tests which doesn't match.

@RealOrangeOne
Copy link
Owner

Damn - it's because they have components of the path which aren't part of the container name. Might need some special-casing for dockerhub.

@RealOrangeOne RealOrangeOne reopened this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants