Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchService is defined in the wrong place #315

Open
pwaller opened this issue Dec 18, 2018 · 0 comments
Open

BatchService is defined in the wrong place #315

pwaller opened this issue Dec 18, 2018 · 0 comments

Comments

@pwaller
Copy link
Contributor

pwaller commented Dec 18, 2018

While investigating #314 I note that BatchService is defined in the wrong place (it's in handlers/api/batch.go when it should be in service) and doesn't implement clean architecture (see #290).

It's possible it is redundant since work along the lines of #311 has taken place, but I'm still firefighting #314 so I have only considered this for a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant