Stairs next to stairs still exhibit incorrect shadow behavior (more obvious when smooth lighting is turned off)

[ninjakitty844]

Describe the bug

Reproducibility

Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

• I reproduced this issue with as few other mods as possible installed. (only Red Core, MixinBooter, ConfigAnytime, Valkyrie, and Alfheim)
• I am unable to reproduce this issue consistently.

To Reproduce

1. Put stairs in a pattern similar to the ones shown in my screenshots

Expected behavior

I think most stair lighting issues would be solved if stairs were prevented from blocking light under all circumstances, I believe that is how modern versions of Minecraft handle stairs.

[Desoroxxx]

would be solved if stairs were prevented from blocking light under all circumstances
That would literally prevent them from being used as a roof

would be solved if stairs were prevented from blocking light under all circumstances
No

Concerning how to fix this there probably is a way but it isn't my priority to work on this issue, everything I can think of as drawbacks.
Also, this is with smooth lighting off, smooth lighting on probably fixes the issue anyway

[ninjakitty844]

Might be that modern stairs only block light on their bottom side and none of the other sides.

idk exactly how it works, but I'd look to modern MC to see how they fixed the issue.

[ninjakitty844]

And mooth lighting only hides the problem a little bitz you can still tell the issue is there with it.

[Desoroxxx]

Might be that modern stairs only block light on their bottom side and none of the other sides.

That would not fix the issues you showed

[XvaleX10]

I have the same issue
without the mod

with the mod

[Desoroxxx]

I have the same issue without the mod with the mod

Oh yeah that's really not right, I will try to take a look.

[MrRedstoneA1]

Also experiencing issues with stairs.

Oh, it also affects slabs but I don't have a screenshot of that atm.

[xskutsu]

Would like to add that it doesn't need to be stairs next to stairs. I'm able to replace the issue with one stair alone. This looks very distracting in any build that uses upside down stairs.

Also the problem still persists with smooth lighting enabled, it is just harder to notice.

[Desoroxxx]

I will take a look at this in the next release

[touhouzun]

Would like to add that it doesn't need to be stairs next to stairs. I'm able to replace the issue with one stair alone. This looks very distracting in any build that uses upside down stairs.

Also the problem still persists with smooth lighting enabled, it is just harder to notice.

yeah dude，in your first picture，the shadow is not fake zero（light level，for client），but real zero（for server），which turns the grass block underneath into dirt.