diff --git a/Changelog.md b/Changelog.md index 42949e55..2c6bf40e 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,3 +1,17 @@ +# Fancier Block Particles Version 0.8 Changelog + +## Fixed + +- Fixed crashes with some moded blocks (#7) + +## Optimization + +## Internal + +### Changes in error handling + +Non critical try-catch blocks should now never throw a runtime exception or print a stacktrace except when debug mode is added they should print a stacktrace and count towards the issues counter and their respective counters (Rendering Issues, Physics Issues, Performance Issues, etc.) + # Fancier Block Particles Version 0.7 Changelog ## Showcase diff --git a/src/main/java/com/TominoCZ/FBP/particle/FBPParticleDigging.java b/src/main/java/com/TominoCZ/FBP/particle/FBPParticleDigging.java index a0dbd081..1ce3d2c3 100644 --- a/src/main/java/com/TominoCZ/FBP/particle/FBPParticleDigging.java +++ b/src/main/java/com/TominoCZ/FBP/particle/FBPParticleDigging.java @@ -2,6 +2,7 @@ import com.TominoCZ.FBP.FBP; import com.TominoCZ.FBP.keys.FBPKeyBindings; +import com.TominoCZ.FBP.model.FBPModelHelper; import com.TominoCZ.FBP.renderer.FBPRenderer; import com.TominoCZ.FBP.util.FBPMathUtil; import com.TominoCZ.FBP.vector.FBPVector3d; @@ -126,7 +127,7 @@ protected FBPParticleDigging(World worldIn, double xCoordIn, double yCoordIn, do destroyed = facing == null; - if (texture == null) { + if (texture == null && FBPModelHelper.isModelValid(state)) { BlockModelShapes blockModelShapes = mc.getBlockRendererDispatcher().getBlockModelShapes(); // GET THE TEXTURE OF THE BLOCK FACE @@ -137,7 +138,7 @@ protected FBPParticleDigging(World worldIn, double xCoordIn, double yCoordIn, do if (!quads.isEmpty()) this.particleTexture = quads.get(0).getSprite(); } catch (Exception e) { - throw new RuntimeException(e); + // TODO: (Debug Mode) This should count to the problem counter and should output a stack trace } } @@ -543,7 +544,6 @@ private void createRotationMatrix() { } @Override - @SideOnly(Side.CLIENT) public int getBrightnessForRender(float partialTicks) { AxisAlignedBB box = getBoundingBox(); @@ -569,4 +569,4 @@ private void calculateYAngle() double getMult() { return Math.sqrt(motionX * motionX + motionZ * motionZ) * (FBP.randomRotation ? 200 : 500) * FBP.rotationMult; } -} \ No newline at end of file +}