Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fancy Block Placement] Rapid placing blocks crash NPE: at net.minecraft.inventory.Slot.putStack #14

Open
Krutoy242 opened this issue Dec 26, 2022 · 3 comments
Assignees
Labels
Bug Something isn't working as intended Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement"

Comments

@Krutoy242
Copy link

Describe the bug

After this issue was fixed, i tested is everything continue working.

When I hold right-click and run, placing Mek Cubes, on moment 6th cube should be placed game crashed.

I tested this issue two times.

dwm_Ga6JsoaWzd

dwm_Gus7sXUhx7

Additional info

  • FBP version: 0.8-Dev-10
  • Optifine NOT installed

Log

java.util.concurrent.ExecutionException: java.lang.NullPointerException
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:192)
    at net.minecraft.util.Util.runTask(SourceFile:531)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1088)
    at net.minecraft.client.Minecraft.run(Minecraft.java:6614)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
Caused by: java.lang.NullPointerException
    at net.minecraft.inventory.Slot.putStack(Slot.java:70)
    at net.minecraft.inventory.Container.setAll(Container.java:527)
    at net.minecraft.client.network.NetHandlerPlayClient.handleWindowItems(NetHandlerPlayClient.java:1191)
    at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SourceFile:50)
    at net.minecraft.network.play.server.SPacketWindowItems.processPacket(SourceFile:12)
    at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at net.minecraft.util.Util.runTask(SourceFile:529)
    ... 9 more

debug.log

@Desoroxxx
Copy link
Member

Pretty sure mekanism playing with multithreading can you test without FBP if this issue happens

@Krutoy242
Copy link
Author

I tested: without FBP this issue not happen.

@Desoroxxx Desoroxxx changed the title Rapid placing blocks crash NPE: at net.minecraft.inventory.Slot.putStack [Fancy Block Placement] Rapid placing blocks crash NPE: at net.minecraft.inventory.Slot.putStack Jan 1, 2023
@Desoroxxx Desoroxxx added Bug Something isn't working as intended Need Investigation labels Jan 1, 2023
@Desoroxxx Desoroxxx added Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement" and removed Need Investigation labels Jan 23, 2023
@Desoroxxx
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement"
Development

No branches or pull requests

2 participants