[Fancier Weather] Digging and snow particles only rotated on Y axis

[Meldexun]

Describe the bug

Digging and snow particles are only rotated around Y axis. In the original FBP digging and snow particles were rotated around the X, Y and Z axis. And depending on the config options they aligned themselves when hitting the ground.

This happens because the code that aligns the digging and snow particles now ignores whether they are on the ground or not. And also because the restOnFloor option was removed.

These are the lines that align the particles:
https://github.com/Red-Studio-Ragnarok/Fancier-Block-Particles/blob/0.8-Refractor-%26-Cleanup/src/main/java/io/redstudioragnarok/FBP/particle/FBPParticleDigging.java#L303-L304
and
https://github.com/Red-Studio-Ragnarok/Fancier-Block-Particles/blob/0.8-Refractor-%26-Cleanup/src/main/java/io/redstudioragnarok/FBP/particle/FBPParticleSnow.java#L144-L145

EDIT: Also in the FastCubeUploader class the rotation is applied in the wrong order. The quaternion should be initialised with the Y axis rotation and the X axis rotation should be done last.
https://github.com/Red-Studio-Ragnarok/Fancier-Block-Particles/blob/0.8-Refractor-%26-Cleanup/src/main/java/io/redstudioragnarok/FBP/renderer/FastCubeUploader.java#L24-L26

To Reproduce

1. Break blocks to spawn digging particles/go to snowy biome and set weather to rain to spawn snow particles
2. Notice that digging and snow particles are only rotated around the Y axis

Expected behavior

I expected that the digging and snow particles are rotated around the X, Y and Z axis while in air and (depending on the config) also while on the ground.

Screenshots or/and videos

This is the current state. You can see that the snow particles in air and on the ground are only rotated around the Y axis.

Minecraft.1.12.2.2023-02-15.21-16-10.mp4

---

Here I added a check if the particle is on ground to the code that aligns the particle if (onGround) { ... }.

Now the snow particles rotate properly again while in the air and get aligned when on the ground. This is how it used to be in the original FBP when you had restOnFloor=true.

Minecraft.1.12.2.2023-02-15.21-16-37.mp4

---

Here I just removed the code that aligns the particle altogether.

Now the snow particles rotate again while in the air and and while on the ground. This is how it used to be in the original FBP when you had restOnFloor=false.

Minecraft.1.12.2.2023-02-15.21-17-02.mp4

Versions

• FBP: latest state of 0.8-Refractor-&-Cleanup branch at time of issue creation
• Forge: 1.12.2-14.23.5.2860
• Java: Eclipse Temurin JDK with Hotspot 8u362-b09 (x64)

Specification:

• OS: Windows 10
• CPU: Ryzen 7 5600
• GPU: RTX 2070
• RAM Allocated: 1GB

All of these info below are not necessary but may become necessary depending on the issue

• CPU Speed: 4.2GHz
• CPU Core: 6
• CPU Threads: 12
• RAM Size: 32GB
• RAM Speed: 3200MHz
• Storage Type: SSD
• GPU VRAM: 8GB

[Desoroxxx]

Fixed in dev build 13