Update Search behavior/styling #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
fhlavac
approved these changes
Nov 11, 2024
Hyperkid123
force-pushed
the
search
branch
2 times, most recently
from
4117cf5 to
9fc2a01
Compare
|
@epwinchell, I've added a commit that changes the Cypress runner to use Chrome, but it also messes a little bit with the configuration. It should fix the issues with different pixel ratios on mac retina display. This way we should not get false positives on the image snapshot reports. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2974 +/- ##
===========================================
- Coverage 64.76% 43.59% -21.17%
===========================================
Files 218 117 -101
Lines 4930 2702 -2228
Branches 943 471 -472
===========================================
- Hits 3193 1178 -2015
+ Misses 1688 1099 -589
- Partials 49 425 +376 |
Hyperkid123
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide search behind icon at all breakpoints
Jira: https://issues.redhat.com/browse/RHCLOUD-36133
New
