RHINENG-10827: unassign systems before template delete

listener/templates.go

@@ -61,14 +61,46 @@ func TemplateDelete(template mqueue.TemplateResponse) error {
 	tStart := time.Now()
 	defer utils.ObserveSecondsSince(tStart, templateMsgHandlingDuration.WithLabelValues(TemplateEventDelete))
 
-	err := database.DB.
-		Delete(&models.Template{}, "uuid = ?::uuid AND rh_account_id = (SELECT id FROM rh_account WHERE org_id = ?)",
-			template.UUID, template.OrgID).Error
-	if err != nil && !errors.Is(err, gorm.ErrRecordNotFound) {
-		utils.LogWarn("template", template.UUID, WarnNoRowsModified)
+	// check account
+	accountID, err := middlewares.GetOrCreateAccount(template.OrgID)
+	if err != nil {
+		utils.LogWarn("org_id", template.OrgID, "err", err)
 		return nil
 	}
-	return err
+
+	var templateID int64
+	err = database.DB.Model(&models.Template{}).
+		Select("id").
+		Where("rh_account_id = ? AND uuid = ?::uuid ", accountID, template.UUID).
+		// use Find() not First() otherwise it returns error "no rows found" if uuid is not present
+		Find(&templateID).Error
+	if err != nil {
+		utils.LogWarn("template", template.UUID, "err", err)
+		return nil
+	}
+
+	// unassign systems from the template
+	err = database.DB.Model(&models.SystemPlatform{}).
+		Where("rh_account_id = ? AND template_id = ?", accountID, templateID).
+		Update("template_id", nil).Error
+	if err != nil {
+		utils.LogWarn("template", template.UUID, "err", err)
+		return nil
+	}
+
+	err = database.DB.
+		Delete(&models.Template{}, "id = ? AND rh_account_id = ?", templateID, accountID).Error
+	if err != nil {
+		if !errors.Is(err, gorm.ErrRecordNotFound) {
+			utils.LogWarn("template", template.UUID, WarnNoRowsModified)
+		} else {
+			utils.LogWarn("template", template.UUID, "err", err)
+
+		}
+		return nil
+	}
+
+	return nil
 }
 
 func TemplateUpdate(template mqueue.TemplateResponse) error {