RHINENG-12951: fix CWE-295 'Improper Certificate Validation'

RedHatInsights · Oct 4, 2024 · 4698cdd · 4698cdd
1 parent 7142826
commit 4698cdd
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/base/mqueue/mqueue_impl_gokafka.go b/base/mqueue/mqueue_impl_gokafka.go
@@ -121,10 +121,8 @@ func tryCreateSecuredDialerFromEnv() *kafka.Dialer {
 	}
 
 	kafkaSslSkipVerify := utils.CoreCfg.KafkaSslSkipVerify
-	var tlsConfig *tls.Config
-	if kafkaSslSkipVerify {
-		tlsConfig = &tls.Config{InsecureSkipVerify: true} // nolint:gosec
-	} else {
+	tlsConfig := &tls.Config{InsecureSkipVerify: kafkaSslSkipVerify} // nolint:gosec
+	if !kafkaSslSkipVerify {
 		tlsConfig = caCertTLSConfig()
 	}