RHINENG-14351: fix candlepin API status handling

fixes 2024/12/13 12:34:43 [Recovery] 2024/12/13 - 12:34:43 panic recovered: runtime error: invalid memory address or nil pointer dereference /go/pkg/mod/github.com/gin-contrib/[email protected]/timeout.go:63 (0x1182204) /go/pkg/mod/github.com/gin-gonic/[email protected]/context.go:185 (0xbdacca)
RedHatInsights · Dec 16, 2024 · 69acadf · 69acadf
1 parent dfc290e
commit 69acadf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/manager/controllers/template_systems_update.go b/manager/controllers/template_systems_update.go
@@ -185,8 +185,10 @@ func callCandlepin(ctx context.Context, consumer string, request *candlepin.Cons
 		statusCode := utils.TryGetStatusCode(resp)
 		utils.LogDebug("request", *request, "candlepin_url", candlepinEnvConsumersURL,
 			"status_code", statusCode, "err", err)
-		if err != nil || statusCode != http.StatusOK {
+		if err != nil {
 			err = errors.Wrap(errCandlepin, err.Error())
+		} else if statusCode != http.StatusOK && statusCode != http.StatusNoContent {
+			err = errors.Errorf("candlepin API status %d", statusCode)
 		}
 		return &candlepinResp, resp, err
 	}