Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upload view permission #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix upload view permission #8

wants to merge 3 commits into from

Conversation

luca-bellenghi
Copy link
Member

read HISTORY.rst report

@luca-bellenghi luca-bellenghi requested a review from cekk May 28, 2018 09:16
@coveralls
Copy link

coveralls commented May 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 41.913% when pulling eb38611 on fix_upload_view into 1496935 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 41.913% when pulling 3c47153 on fix_upload_view into 1496935 on master.

@luca-bellenghi
Update configure.zcml
afb6e34 
Change permission according to base view
pnicolli
pnicolli reviewed May 29, 2018
View reviewed changes
Copy link
Member

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: is the new History correct? There seems to be a discrepancy in the zcml file that says the permission changed to zope2.View and the History that says it changed to cmf.AddPortalContent

pnicolli
pnicolli reviewed May 29, 2018
View reviewed changes
docs/HISTORY.rst Outdated
@@ -4,7 +4,9 @@ Changelog
2.1.1 (unreleased)
------------------

- Nothing changed yet.
- Change fileupload view permission: collective.limitfilesizepanel.LimitFileSizePanel
is too strinct. Better a cmf.AddPortalContent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Did you mean strict?

@luca-bellenghi
Update HISTORY.rst
eb38611 
Fix some typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolli pnicolli pnicolli left review comments

@cekk cekk Awaiting requested review from cekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-bellenghi @coveralls @pnicolli