From add9bb9c64fab6fc646b8b862ff0a0bfd36b7ef9 Mon Sep 17 00:00:00 2001
From: Laurent Droin <32528572+laurentdroin@users.noreply.github.com>
Date: Tue, 29 Dec 2020 17:59:52 -0800
Subject: [PATCH 1/2] Updating the verification steps

The update was done for the regular admission controller, but not for Gesher. It is now OK to have a REDB that has no REC name.
---
 admission/GESHER.md | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/admission/GESHER.md b/admission/GESHER.md
index ec275cc..9dc0679 100644
--- a/admission/GESHER.md
+++ b/admission/GESHER.md
@@ -239,12 +239,14 @@ $ kubectl apply -f - << EOF
 apiVersion: app.redislabs.com/v1alpha1
 kind: RedisEnterpriseDatabase
 metadata:
-  name: test-database-custom-resource
+  name: redis-enterprise-database
+spec:
+  evictionPolicy: illegal
 EOF
 ```
 
-This must fail with an error output by the admission webhook redb.admisison.redislabs that is being denied because it can't get the login credentials for the Redis Enterprise Cluster as none were specified.
+This must fail with an error output by the admission webhook proxy.webhook.gesher that is being denied because 'illegal' is not a valid eviction policy.
 
 ```shell script
-Error from server: error when creating "STDIN": admission webhook "proxy.webhook.gesher" denied the request: proxied webhook webhook denied the request: failed get RedisEnterpriseCluster client: custom resource (RedisEnterpriseCluster) not found: resource name may not be empty
-```
\ No newline at end of file
+Error from server: error when creating "adm_redb.yaml": admission webhook "proxy.webhook.gesher" denied the request: proxied webhook webhook denied the request: eviction_policy: u'illegal' is not one of [u'volatile-lru', u'volatile-ttl', u'volatile-random', u'allkeys-lru', u'allkeys-random', u'noeviction', u'volatile-lfu', u'allkeys-lfu']
+```

From cc3415486fd35ab4257a1c38fd579e50339afcd8 Mon Sep 17 00:00:00 2001
From: Laurent Droin <32528572+laurentdroin@users.noreply.github.com>
Date: Tue, 29 Dec 2020 18:18:08 -0800
Subject: [PATCH 2/2] Fixing typo

---
 admission/GESHER.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/admission/GESHER.md b/admission/GESHER.md
index 9dc0679..e94e867 100644
--- a/admission/GESHER.md
+++ b/admission/GESHER.md
@@ -248,5 +248,5 @@ EOF
 This must fail with an error output by the admission webhook proxy.webhook.gesher that is being denied because 'illegal' is not a valid eviction policy.
 
 ```shell script
-Error from server: error when creating "adm_redb.yaml": admission webhook "proxy.webhook.gesher" denied the request: proxied webhook webhook denied the request: eviction_policy: u'illegal' is not one of [u'volatile-lru', u'volatile-ttl', u'volatile-random', u'allkeys-lru', u'allkeys-random', u'noeviction', u'volatile-lfu', u'allkeys-lfu']
+Error from server: error when creating "STDIN": admission webhook "proxy.webhook.gesher" denied the request: proxied webhook webhook denied the request: eviction_policy: u'illegal' is not one of [u'volatile-lru', u'volatile-ttl', u'volatile-random', u'allkeys-lru', u'allkeys-random', u'noeviction', u'volatile-lfu', u'allkeys-lfu']
 ```