Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Rebrand android editor to allow play store signing #849

Merged

Conversation

trashguy
Copy link
Contributor

@trashguy trashguy commented Nov 8, 2024

Rebrand of the android object naming to allow upload to the Google play store and signing. This will allow users to load the app on their Android devices.

We are waiting on Google to approve our account, so lets keep this open until I can verify the builds on the Play store.

@trashguy trashguy force-pushed the fix/android-editor-build-rebrand branch from 6d00198 to 0b598d6 Compare November 9, 2024 00:20
@trashguy trashguy added rebranding issues and pr's related to engine rebranding platform:android labels Nov 9, 2024
@Spartan322 Spartan322 changed the title Rebrand android editor to allow play store signing [4.3] Rebrand android editor to allow play store signing Nov 9, 2024
@Spartan322 Spartan322 added bug cherrypick:master Considered for cherry-picking into a master topic:editor labels Nov 9, 2024
Copy link
Member

@Spartan322 Spartan322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm these changes currently crash on my android emulator.

@Spartan322
Copy link
Member

platform/android/java_godot_lib_jni.h and platform/android/plugin/godot_plugin_jni.h need their function names changed to reflect the package.

@Spartan322
Copy link
Member

platform/android/java_godot_wrapper.cpp and platform/android/jni_utils.cpp need to change from look for something in org/godotengine/godot/ to org/redotengine/godot/
and
"()Lorg/godotengine/godot/GodotRenderView;" needs to be changed to "()Lorg/redotengine/godot/GodotRenderView;" in platform/android/java_godot_wrapper.cpp

@trashguy
Copy link
Contributor Author

Patched your changes @Spartan322 and updated the editor name

@Spartan322
Copy link
Member

Spartan322 commented Nov 13, 2024

This needs to be squashed, you can add my name to the commit by adding Co-authored-by: Spartan322 <[email protected]> at the end of the commit.

@Spartan322 Spartan322 self-requested a review November 13, 2024 11:15
@Spartan322 Spartan322 dismissed their stale review November 13, 2024 11:16

Allow others to review

@trashguy trashguy force-pushed the fix/android-editor-build-rebrand branch from fee5442 to 7bc5e08 Compare November 13, 2024 14:03
@trashguy trashguy force-pushed the fix/android-editor-build-rebrand branch from 7bc5e08 to 621c8c8 Compare November 13, 2024 14:07
@trashguy trashguy merged commit 9b54c83 into Redot-Engine:4.3 Nov 13, 2024
18 checks passed
@Spartan322 Spartan322 removed the cherrypick:master Considered for cherry-picking into a master label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug platform:android rebranding issues and pr's related to engine rebranding topic:editor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants