Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tryed your example site #1

Open
paladox opened this issue Nov 21, 2015 · 11 comments
Open

Tryed your example site #1

paladox opened this issue Nov 21, 2015 · 11 comments

Comments

@paladox
Copy link

paladox commented Nov 21, 2015

Ive tried you example site but when I refresh it still goes to the start.

@sprice
Copy link
Contributor

sprice commented Nov 21, 2015

This makes me think my work with localStorage might be off. Can you let me know what browser you're using, browser version, and OS version?

@paladox
Copy link
Author

paladox commented Nov 21, 2015

I am using windows 10, Internet Explorer 11.

@sprice
Copy link
Contributor

sprice commented Nov 21, 2015

I just emailed Browserstack asking for a free open source account. I'll be able to test this myself as soon as I hear back. In the meantime I did some googling and it does look like IE has some issues with localStorage. I'll likely need to end up using a wrapper like https://github.com/marcuswestin/store.js. Check back soon!

@paladox
Copy link
Author

paladox commented Nov 21, 2015

Thanks.

@sprice
Copy link
Contributor

sprice commented Nov 22, 2015

I just pushed a new version. Take a test. (see updated README)

@paladox
Copy link
Author

paladox commented Nov 22, 2015

Yes it nows works.

A few bugs.

The bugs are sometimes it wont show the resume button even though your a bit in the video.

When it does resume it may miss a few seconds even before or after.

@sprice
Copy link
Contributor

sprice commented Nov 23, 2015

The example sets playbackOffset to 5 so that playback begins 5 seconds before the video was left. I wonder if it would make sense for the example to just not include this?

@sprice
Copy link
Contributor

sprice commented Nov 26, 2015

I removed playbackOffset from the example. It should always resume right where it left off. I've tested on quite a few browsers and am unable to reproduce the resume button not showing up when it's expected to.

@paladox
Copy link
Author

paladox commented Nov 26, 2015

Thanks.

When you refresh the browser twice the resume button shows when you press it goes back to start if you refresh once and you press the resume button it works if you refresh more then once the resume button shows but doesn't work as expected.

@sprice
Copy link
Contributor

sprice commented Nov 27, 2015

I'm testing in IE11 on Win 10 using the current demo link from the Readme. I seek ahead to the middle of the video while it's playing. Then I refresh it multiple times. No matter how many times I refresh it it always picks up playing where I expect it to.

Not sure how else I can test this.

@sprice
Copy link
Contributor

sprice commented Feb 4, 2016

@paladox I'd really like to make sure this is working for all modern browsers. Is there any chance you could record a screen cast of it not working so I could get a better idea of the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants