Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreJS compatability #80

Open
heyakyra opened this issue Mar 5, 2014 · 12 comments
Open

LibreJS compatability #80

heyakyra opened this issue Mar 5, 2014 · 12 comments

Comments

@heyakyra
Copy link

heyakyra commented Mar 5, 2014

This means that for the website to be fully free software, the JavaScript must also be free. It should be tested with the LibreJS plugin: https://www.gnu.org/software/librejs/

A few steps are required:

@johana-star
Copy link
Contributor

@tkwidmer To resolve this issue, we'd need to remove our Google dependencies. Will this happen in the next three months? If so, keep the issue open, otherwise I think we should close this issue.

@tkwidmer
Copy link
Contributor

I'd love to see it done in the next three months. So we can leave it open for now? It would be nice to be completely open source / free. My only concern about this is i'm not sure how accurate the OSM geoloating is and if there is a JS way to do it.

Currently we use JS client side to geolocate search strings before passing to our server (so we don't hit API call limits). We would need to maintain this functionality but using OSM for the lookup service.

The other two places we Geolocate is on the new bathrooms page when folks try to guess their current location to auto fill some of the fields. Or upon new bathroom entry with an address. I belive the current location is done is JS on client side and the new bathroom entery is done using geocoder on the server using google, which can be changed to OSM fairly easily.

Google analytics should be fairly easy to replace / delete.

@johana-star
Copy link
Contributor

Ok, we should probably break this into a few separate issues and make LibreJS into a milestone.

  • replace Google Maps with Open Street Maps
  • remove Google Analytics (what free tools replace this?)

While we are at it, we should get our JS under test… can we use Jasmine as our testing framework? The general rule I'd follow here is no new JS can be committed without some test coverage.

@tkwidmer
Copy link
Contributor

Sounds good to me @strand

@kiesia
Copy link
Contributor

kiesia commented Apr 23, 2014

@strand piwik is a drop in replacement for google analytics. You need to install it yourself somewhere though (mysql/php). If there's no other options, I could install it on a server and admin it.

Jasmine would be awesome.

@johana-star
Copy link
Contributor

I think there are a couple of separate projects here… One is defining our distinctive testing strategy, the other is replacing Google products with FLOSS alternatives. I have a good idea of what that first looks like (replace cucumber tests with RSpec/Capybara, audit existing RSpec, establish Jasmine tests, get JS under test) and feel capable of leading that effort. @kiesia I think you are capable and interested in ensuring that we are only using FLOSS tech. Would you lead this effort?

@kiesia
Copy link
Contributor

kiesia commented Apr 28, 2014

@strand Sure I can take that on.

Agree about the tests too, would be great to get rid of cucumber and get the js tested. Is there discussion needed about this? If not I'll just write a feature test for the versioning feature I'm writing.

@mathonsunday
Copy link
Contributor

Ahoy seems like a good replacement for Google Analytics https://github.com/ankane/ahoy

@backspace
Copy link
Contributor

Hello, I only used Cucumber because it’s what I knew, and if people want to change it RSpec, works for me, excited to see what it’s like

@kiesia kiesia self-assigned this Aug 19, 2014
@kiesia
Copy link
Contributor

kiesia commented Aug 19, 2014

I'm assigning myself to this to set up a server with piwik.

@tkwidmer
Copy link
Contributor

👍

@kiesia
Copy link
Contributor

kiesia commented Jan 30, 2015

I've forked off this issue to a much more manageable #200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants