Re-type IMessageComponentData.cs#Values as a union array of snowflakes or strings

Backend/Remora.Discord.API.Abstractions/API/Objects/Interactions/IMessageComponentData.cs

@@ -22,6 +22,7 @@
 
 using System.Collections.Generic;
 using JetBrains.Annotations;
+using OneOf;
 using Remora.Rest.Core;
 
 namespace Remora.Discord.API.Abstractions.Objects;
@@ -52,10 +53,5 @@ public interface IMessageComponentData
     /// <summary>
     /// Gets the values selected by the user.
     /// </summary>
-    /// <remarks>
-    /// The Discord API docs denote that this field should contain a list of
-    /// <see cref="ISelectOption"/> values. However, in their samples and as
-    /// identified through testing, it actually always contains a list of strings.
-    /// </remarks>
-    Optional<IReadOnlyList<string>> Values { get; }
+    Optional<OneOf<IReadOnlyList<Snowflake>, IReadOnlyList<string>>> Values { get; }
 }

Backend/Remora.Discord.API/API/Objects/Interactions/MessageComponentData.cs

@@ -22,6 +22,7 @@
 
 using System.Collections.Generic;
 using JetBrains.Annotations;
+using OneOf;
 using Remora.Discord.API.Abstractions.Objects;
 using Remora.Rest.Core;
 
@@ -34,5 +35,5 @@ public record MessageComponentData
     string CustomID,
     ComponentType ComponentType,
     Optional<IApplicationCommandInteractionDataResolved> Resolved,
-    Optional<IReadOnlyList<string>> Values
+    Optional<OneOf<IReadOnlyList<Snowflake>, IReadOnlyList<string>>> Values
 ) : IMessageComponentData;

Remora.Discord.Interactivity/Responders/InteractivityResponder.cs

@@ -30,7 +30,6 @@
 using Remora.Commands.Services;
 using Remora.Commands.Tokenization;
 using Remora.Commands.Trees;
-using Remora.Discord.API;
 using Remora.Discord.API.Abstractions.Gateway.Events;
 using Remora.Discord.API.Abstractions.Objects;
 using Remora.Discord.API.Abstractions.Rest;
@@ -155,13 +154,7 @@ or ComponentType.MentionableSelect
         var buildParameters = data.ComponentType switch
         {
             ComponentType.Button => new Dictionary<string, IReadOnlyList<string>>(),
-            ComponentType.StringSelect => Result<Dictionary<string, IReadOnlyList<string>>>.FromSuccess
-            (
-                new Dictionary<string, IReadOnlyList<string>>
-                {
-                    { "values", data.Values.Value }
-                }
-            ),
+            ComponentType.StringSelect => BuildParametersFromStringData(data),
             ComponentType.UserSelect
                 or ComponentType.RoleSelect
                 or ComponentType.MentionableSelect
@@ -185,6 +178,23 @@ or ComponentType.ChannelSelect
         return await TryExecuteCommandAsync(context, commandPath, parameters, ct);
     }
 
+    private static Result<Dictionary<string, IReadOnlyList<string>>> BuildParametersFromStringData
+    (
+        IMessageComponentData data
+    )
+    {
+        // In the case that the developer defined options are similar to Snowflakes, they'll
+        // be incorrectly parsed. Hence, we have to handle either case for string selects.
+        var values = data.Values.Value.TryPickT1(out var stringValues, out var snowflakeValues)
+            ? stringValues
+            : snowflakeValues.Select(x => x.ToString()).ToList();
+
+        return new Dictionary<string, IReadOnlyList<string>>
+        {
+            { "values", values }
+        };
+    }
+
     private static Result<Dictionary<string, IReadOnlyList<string>>> BuildParametersFromResolvedData
     (
         IMessageComponentData data
@@ -193,11 +203,11 @@ IMessageComponentData data
         var parameters = new Dictionary<string, IReadOnlyList<string>>();
 
         var values = new HashSet<Snowflake>();
-        foreach (var value in data.Values.Value)
+        if (data.Values.Value.TryPickT0(out var snowflakes, out _))
         {
-            if (DiscordSnowflake.TryParse(value, out var parsed))
+            foreach (var snowflake in snowflakes)
             {
-                values.Add(parsed.Value);
+                values.Add(snowflake);
             }
         }