-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TargetNetStandard switch #11
Conversation
I think I got these fixed. |
| ExecutableFrameworks* | net7.0 | Yes | | ||
| TargetFramework | | Yes | | ||
| TargetFrameworks | (varies) | Yes | | ||
| TargetNetStandard | true | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing an asterisk here to mark the property as a Remora extension.
Looks like something broke with your latest changes. Can you take a closer look at what's going on? |
For some reason on build, the Project.AssemblyInfo.cs files for the test libraries end up with a duplicate |
Afraid not - the SDK does add that attribute in certain cases, and your best bet would be to either use a git bisect or combinations of the involved properties (old and new) to identify the exact failure case. |
As discussed in the Discord. Adds a new switch,
<TargetNetStandard />
which accepts a value of true or false (default true), to allow optionally targeting netstandard2.1.Use:
This should also be settable in the solution's
Directory.Build.props
if one desires to configure this at that level.