Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflict with settings search? #65

Open
ksdavidc opened this issue Feb 1, 2023 · 1 comment
Open

conflict with settings search? #65

ksdavidc opened this issue Feb 1, 2023 · 1 comment

Comments

@ksdavidc
Copy link

ksdavidc commented Feb 1, 2023

Describe the bug

getting this message consistently in developer console

seems to be a conflict with settings search and will post problem there too...
turning off settings search eliminates error message

plugin:obsidian-markdown-formatting-assistant-plugin:5107 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'active')
    at eval (plugin:obsidian-markdown-formatting-assistant-plugin:5107:56)
    at e.addToggle (app.js:1:1135946)
    at SettingsTab.eval (plugin:obsidian-markdown-formatting-assistant-plugin:5106:22)
    at step (plugin:obsidian-markdown-formatting-assistant-plugin:79:23)
    at Object.eval [as next] (plugin:obsidian-markdown-formatting-assistant-plugin:60:53)
    at eval (plugin:obsidian-markdown-formatting-assistant-plugin:53:71)
    at new Promise (<anonymous>)
    at __awaiter (plugin:obsidian-markdown-formatting-assistant-plugin:49:12)
    at SettingsTab.display (plugin:obsidian-markdown-formatting-assistant-plugin:4893:16)
    at SettingsSearch.getTabResources (plugin:settings-search:170:15)

To Reproduce
Steps to reproduce the behavior:

  1. open obsidian and developer tools with this plugin and setting search plugin
  2. See error
  3. disable setting search and restart
  4. no error

Expected behavior
no error
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS] MAC
  • Browser [e.g. chrome, safari] MAC
  • Version [e.g. 22] recent
    -Obsidian 1.1.9

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@valentine195
Copy link

Settings Search forces plugin SettingTabs to render when initialized to grab plugin settings to search for, but I don’t see anything at a quick glance through this plugin’s code that would cause this error… seems like you’d get this with or without the settings search plugin if it happens at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants