Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] change imageUrl to image #2

Closed
yibeichan opened this issue Dec 21, 2023 · 4 comments
Closed

[TODO] change imageUrl to image #2

yibeichan opened this issue Dec 21, 2023 · 4 comments
Assignees

Comments

@yibeichan
Copy link
Collaborator

in the current version, i changed image to imageUrl to pass the validation


once this PR (ReproNim/reproschema#453) is merged, we need to change it back to image

@yibeichan yibeichan self-assigned this Dec 21, 2023
@satra
Copy link

satra commented Dec 21, 2023

i think i remember why we created imageUrl - to allow for validating. in generic, the only difference in imageUrl is the addition of type. so we should check how schema.org validates objects with multiple types.

@yibeichan
Copy link
Collaborator Author

@djarecka how's our current validation dealing with imageUrl? should we keep it or change it to image?

@djarecka
Copy link
Member

change to image

@yibeichan
Copy link
Collaborator Author

okay, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants