Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in "author and reviewer meet" section: include language about cultural differences #69

Open
NickleDave opened this issue Apr 8, 2022 · 0 comments

Comments

@NickleDave
Copy link
Collaborator

more feedback from Collab22:
in "author and reviewer meet" section of "perform code review", should have language re-iterating that author and reviewer should have conversations about and agree on what is "safe" and how they prefer to receive feedback

being prescriptive about what is risky, what is safe
re: cultural differences
some ppl might prefer more direct feedback

ofc, ppl can have different communication styles for many reasons but one is cultural differences that may go unconsidered

Both @RaoOfPhysics and Matt Alexandrakis made similar points in our discussion
(again tagging to credit later when possible, couldn't find a GH profile for Matt who is an RSE at QMUL)

@NickleDave NickleDave mentioned this issue Apr 21, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant