Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify some parts of the tutorial #6

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

ross-spencer
Copy link
Contributor

Instructions

Thanks for contributing! ❤️

If this contribution is for instructor training, please email the link to this contribution to
[email protected] so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!

Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at [email protected].

You may delete these instructions from your comment.

- The Carpentries

I found a few small tweaks that could be made in the tutorial to make it clearer for those building their solution while working through it, or to provide more context as to why folks might be doing something in particular.

I build and tested the site locally using the Makefile and it looked okay.

I have committed each change as a separate commit so that they can be reviewed independently of each other and cherry-picked via git if they are useful.

Thanks for this great resource, a very useful crash course for me today!

ross-spencer and others added 6 commits January 31, 2025 17:26
It is a bit late to reminder users about this in chapter nine. We
can do this the first time we add a new JSON object.
The concept of an array describing a Dataset and LearningResource
is introduced early on but not reflected here in the tutorial. It then
reappears in final RO-Crate Metadata Document.
Making sure users know that to get more out of the visualization they
have to click on the resources makes sense here. Some may otherwise
just look at the first result provided by the JSON-LD playground.
It's important to bring forward why we are doing something in a text.
Some contextualizing information about the base URI is provided here
and then it can be revisited in the conclusions of this episode.
Copy link
Contributor

@elichad elichad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are nice improvements, thank you @ross-spencer !

@elichad
Copy link
Contributor

elichad commented Feb 5, 2025

Ah, I ran the checks forgetting they are broken. That's for me to fix - I'll go ahead and merge this :)

@elichad elichad merged commit 4831eba into ResearchObject:gh-pages Feb 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants