Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool to remove data-sizes and scrset from image elements in the post content #271

Closed
wants to merge 4 commits into from

Conversation

jaspermdegroot
Copy link
Member

Solution for #178

If there are posts that contain images with data-sizes and srcset attributes in the markup a menu page is added to the Tools menu and a warning message is shown on the dashboard and plugin menu page to point users to this page.

The plugin Tools menu page contains an explanation, a tool to automatically remove data-sizes and srcset from images, and instructions how to do this manually.

When all data-sizes and srcset are removed the Tools menu page and the warning message disappear.

@jaspermdegroot
Copy link
Member Author

Still have to look into unit tests.

@damienroue
Copy link

damienroue commented Jun 30, 2016

Hi @jaspermdegroot. Have you found a way to remove srcset and sizes markup?

@jaspermdegroot
Copy link
Member Author

Hi @damienroue

Yeah, this PR adds a tool to remove the attributes. It still needs to be reviewed by @joemcgill before we can merge and release a new version of the plugin with the tool. I also have to see why some tests failed on the last commit. Everything worked fine when I tested the code, but make sure you have a backup of your database if you decide to use it already!

@joemcgill joemcgill closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants