Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmppTransactionHandle is not unique enough on reset of SMPP connections #142

Closed
faizann opened this issue Nov 2, 2016 · 1 comment
Closed

Comments

@faizann
Copy link
Collaborator

faizann commented Nov 2, 2016

At present SmppTransactionHandle is created using ESME name and sequence number from SubmitSM/DeliverSM. This mechanism is not unique enough and causes issues in case an SMPP client connects/disconnects at short intervals due to network issues or by design. The sequence numbers are restarted from 0 on smpp clients mostly and thus SMSC errors out stating Activity/Handle already exists.

We need a way to may be use socketId or connectiontime as an added key to uniquely create SMPP transactions in the system.

https://github.com/RestComm/smscgateway/blob/master/core/slee/resource-adaptors/smpp-server-ra/ra/src/main/java/org/mobicents/smsc/slee/resources/smpp/server/SmppTransactionHandle.java#L38

@vetss
Copy link
Contributor

vetss commented Dec 27, 2016

This issue concerns to a separated now smpp-extensions project. A created corresponded issue:
RestComm/smpp-extensions#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants