Feature: Issue Query Digest

[tleish]

SUMMARY:

I've coded a new feature that I think would be a great addition to this plugin, but have one last piece that I need advice on.

DETAILS

We have a need at our company to be able to email digests based on custom criteria (e.g. custom fields). An easy way to accomplish this is using Redmines Issue Query. In the Redmine Digest Rule configuration, I added a new option in the Project dropdown "For any issue update on the selected issue query". Then a 2nd dropdown with a list of saved Redmine Issue Queries.

To persist the configuration, I saved the new project_selector issue_query and the Issue queries.id.

QUESTION:

Which approach would be preferable?

Option 1: Keep fields the same name

Since this is the easiest solution, I got this working, but I'm not sure it's the right solution.

digest_rules.project_selector = 'issue_query'
digest_rules.project_ids = <queries.id>

Option 2: Add a new field issue_query_id

digest_rules.project_selector = 'issue_query'
digest_rules.issue_query_id = <queries.id>

Option 3: Rename project_selector and project_ids fields

digest_rules.selector_type = 'issue_query'
digest_rules.selector_ids = <queries.id>