[Paywalls V2] Extend paywall content below sticky footer #2125
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
changed the title
tonidero
force-pushed
the
extend-paywall-content-below-sticky-footer
branch
from
dfad7b6 to
ddac42d
Compare
📸 Snapshot Test2 modified, 197 unchanged
🛸 Powered by Emerge Tools |
tonidero
commented
Feb 7, 2025
| .verticalScroll(rememberScrollState()), | ||
| ) | ||
| Box(modifier = modifier.background(background)) { | ||
| var footerHeight by remember { mutableIntStateOf(0) } |
There was a problem hiding this comment.
I thought about using SubcomposeLayout for this instead but I was running into issues applying the padding and making it look right and this seemed easier for this use case. wdyt?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
+ Coverage 80.73% 80.76% +0.02%
==========================================
Files 274 274
Lines 9228 9252 +24
Branches 1295 1297 +2
==========================================
+ Hits 7450 7472 +22
- Misses 1230 1234 +4
+ Partials 548 546 -2 ☔ View full report in Codecov by Sentry. |
|
The preview changes in emerge are due to the recomposition caused by the |
tonidero
force-pushed
the
extend-paywall-content-below-sticky-footer
branch
from
dc9b4d2 to
5cf6c41
Compare
|
We still want to do this but not for the open beta. Until then, leaving this as draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the sticky footer and main paywall content are part of a column, so there is no overlap between them. This makes it so the paywall content can extend below the sticky footer in case the sticky footer has a transparent background.
Ignore the extended badge but now the background extends below the footer: