Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing DoF in subassembly #76

Open
thomasfla opened this issue Jun 17, 2022 · 5 comments
Open

Managing DoF in subassembly #76

thomasfla opened this issue Jun 17, 2022 · 5 comments

Comments

@thomasfla
Copy link

Hi, thanks for this super tool!

I'm wondering it is possible to have some DoF defined inside an assembly which is itself included inside a global assembly multiple time.
I guess this will lead to naming issues, but maybe could be fixed by adding a suffix?
At the moment, onshape-to-robot detects 0 dof.

It this is not doable, I can of course simply make a big assembly.

@Gregwar
Copy link
Contributor

Gregwar commented Jun 17, 2022

Hello,
I agree that it might be easier, but it would require deeper rework of the logic
Actually, some current constraints can be lightened by refactoring/rewriting onshape-to-robot, hopefuly I will have some time to do that someday

@Gregwar
Copy link
Contributor

Gregwar commented Jun 17, 2022

Just for the detail; currently the problem is also that non-dof relation (like two parts being fastened together) don't work on top-level assembly (that could also be improved)

@thomasfla
Copy link
Author

Thanks for the fast response, I'll then do a separate flat "link level" assembly for the URDF export.

@Achllle
Copy link

Achllle commented Oct 9, 2023

This is a pretty important feature to have. Most complex assemblies will have DOFs defined in a subassembly.

@Gregwar, you wrote

it would require deeper rework of the logic
Actually, some current constraints can be lightened by refactoring/rewriting onshape-to-robot, hopefuly I will have some time to do that someday

Curious if that day will come soon? Alternatively I can try to tackle this one issue if you could share high level steps on how this is easiest accomplished - preferably without requiring a big refactor.

@Gregwar
Copy link
Contributor

Gregwar commented Feb 20, 2025

Big refactor happened recently
However there are still some work to be done if we want to reach that feature 🙂

From my current understanding on how I would implement that, there are underlying hard problems to tackle. Mostly, considering features in all the sub assemblies would mean that all the parts present in the robot would become candidates to be their very own link. In that case, it become less clear what is actually a body, it would need an analysis of all the features to understand which bodies are "weld" together and what can move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants