Skip to content
This repository has been archived by the owner on Mar 13, 2019. It is now read-only.

Make an official composer Docker container #40

Open
2 of 4 tasks
RobLoach opened this issue Apr 7, 2016 · 11 comments
Open
2 of 4 tasks

Make an official composer Docker container #40

RobLoach opened this issue Apr 7, 2016 · 11 comments

Comments

@RobLoach
Copy link
Owner

RobLoach commented Apr 7, 2016

Would be nice to have this as one of the "official" repositories available in Docker....

@RobLoach RobLoach changed the title Make an official image Make an official composer Docker container Apr 7, 2016
@RobLoach RobLoach mentioned this issue Apr 25, 2016
@zoidyzoidzoid
Copy link

zoidyzoidzoid commented Jun 9, 2016

This would be really awesome as part of the official library.

Could we also do PHP 7 versions before we add it to the official library?

(I see they're there, I just missed them in the readme, my bad.)

@alcohol
Copy link

alcohol commented Sep 30, 2016

I am rather surprised you dare call any of this "official", considering you did not even reach out to us and blatantly registered our name as your organization and use our logo for it.

@RobLoach
Copy link
Owner Author

RobLoach commented Sep 30, 2016

@alcohol I've spoken with Seldaek about this, he found it best to keep the Docker container off the GitHub /composer org. By "official", what I mean have the repository live in the /docker-library org so that you use it as composer rather then composer/composer.

Is there anything you'd like to see improved? Would you like repo write access?

@alcohol
Copy link

alcohol commented Sep 30, 2016

This is your project, so I'm not going to ask you to move it to our Github organization. I know Seldaek prefers not to endorse third party tools/components when he is not involved with them himself. I personally am quite fond of Docker though, and would like to contribute or be involved, if possible.

I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.

I can imagine that releasing it under the composer namespace is a lot more attractive than releasing it under your personal namespace, but it is a somewhat questionable move.

@RobLoach
Copy link
Owner Author

RobLoach commented Sep 30, 2016

This is your project, so I'm not going to ask you to move it to our Github organization.

I actually asked Seldaek to move it to /composer a while ago, and he said no.

I am simply a bit baffled by the fact that you registered the composer organization on the docker hub, rather than simply asking us to proxy it for you.

I added the Composer maintainers of who I found had Docker Hub accounts. There was lots of transparency behind it, across both IRC, and the issue queue. The project is almost two years old at this point, and its has been growing. Contributions from others like alpine support and supporting both PHP 5/7 helped keep it alive. I'd like for it to grow even further, if you have any ideas on a direction, feel free to propose them.

I've added you to both the GitHub and the Hub org. Would love your thoughts on how it could improve.

@alcohol
Copy link

alcohol commented Sep 30, 2016

Cheers for the invitation. I do not recognize any of the other "owners" of the docker organization though, so I'm not sure who you added.

I'll have a closer look at my earliest convenience. The only possible addition/improvement I can think of from the top of my mind right now, is to create images based on Git tags, to provide a containerized counterpart for each version that is also offered at https://getcomposer.org/download/

@alcohol
Copy link

alcohol commented Sep 30, 2016

For the alpine based Dockerfile you could consider using --no-cache instead of --update (read more).

@alcohol
Copy link

alcohol commented Oct 4, 2016

I have some (possibly radical) changes to suggest and various other things I would like to discuss. Can I reach you on a medium that is a bit more direct than the Github issue tracker? E.g. Twitter DM, IRC, or some Slack channel?

@sylus
Copy link
Contributor

sylus commented Oct 4, 2016

Some slack channel would be great so other collaborators who use this and / or extend from this image can also be in the loop.

@alcohol
Copy link

alcohol commented Oct 4, 2016

We could also use Gitter to keep it simple.

@alcohol
Copy link

alcohol commented Oct 4, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants