You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
We don't currently disconnect events before we start unmounting host components.
This means that you can get event callbacks during unmounting, which means that refs are generally nil, you can't call setState, and generally things are in weird states.
We should update RobloxRenderer.unmountHostNode to iterate through all Roact.Event and Roact.Change props and disconnect them.
There may be cases in existing Roact projects where layout events are firing as children are being destroyed, and we might be doing a significant number of extraneous size changes.
The text was updated successfully, but these errors were encountered:
We don't currently disconnect events before we start unmounting host components.
This means that you can get event callbacks during unmounting, which means that refs are generally
nil
, you can't callsetState
, and generally things are in weird states.We should update
RobloxRenderer.unmountHostNode
to iterate through allRoact.Event
andRoact.Change
props and disconnect them.There may be cases in existing Roact projects where layout events are firing as children are being destroyed, and we might be doing a significant number of extraneous size changes.
The text was updated successfully, but these errors were encountered: