Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ring information #27

Open
facontidavide opened this issue Jul 28, 2019 · 7 comments
Open

Adding Ring information #27

facontidavide opened this issue Jul 28, 2019 · 7 comments

Comments

@facontidavide
Copy link

Hi,

I think it would be nice to add the ring information to the pointcloud, similarly to Velodyne and Ouster.

The changes are pretty simple and I can easily send a PR myself, if you want.

What do you think?

@JangGyoungHoon
Copy link

@facontidavide

hi, Do you have a ring information added ros driver code.

If you can possible, could you give me the your code.

my mail address is [email protected]

Thanks,

gyounghoon.

@facontidavide
Copy link
Author

I would rather create a branch here https://github.com/facontidavide/ros_rslidar

I will let you know

@facontidavide
Copy link
Author

facontidavide commented Aug 1, 2019

I had NO opportunity yet to test this (because I don't have the physical sensor with me this week), but here you can find the preliminary code.

https://github.com/facontidavide/ros_rslidar/tree/ring

@JangGyoungHoon it would be nice if you test it with RViz and see if the ring field works es expected. Let me know.

@facontidavide
Copy link
Author

For your information, the update code is here https://github.com/facontidavide/ros_rslidar/tree/add_ring_to_pointcloud

@TillBeemelmanns
Copy link

Hi @facontidavide ,
thanks for providing the preliminary code for the ring information. Unfortunately, when I try your code, I do not obtain correct results using the RS32. The ring numbers are not in order.
robosense_ring

Any chance that you could revisit your code ?

@facontidavide
Copy link
Author

I moved to another job and unfortunately I don't have anymore any physical access to one of your sensors. I am afraid I don't have the ability to properly test this anymore

@nubertj
Copy link

nubertj commented Sep 29, 2022

Is there any update on this?
Having the ring information would be super useful, in particular if rings are not uniformly distributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants