cpplint: Disable whitespace/todo #13763
Conversation
In preparation for enabling C-style comment linting, we disable the whitespace rules for TODOs. They go beyond what GSG demands, and it is unclear how to apply them to C-style comments.
There was a problem hiding this comment.
+@SeanCurtis-TRI
Reviewed 1 of 1 files at r1.
Reviewable status: needs at least two assigned reviewers
There was a problem hiding this comment.
Reviewable status: labeled "do not merge" (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: labeled "do not merge" (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: labeled "do not merge" (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Did this just enforce that there is a single space between the TODO() and the text in TODO(someone) text or is it more subtle? If it's just that why is it a problem in a C-style comment?
Reviewable status: labeled "do not merge" (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Per f2f: thanks!
Reviewable status: labeled "do not merge" (waiting on @rpoyner-tri)
For the record -- yes, it did that but it also enforced exactly once space at the start |
|
Hearing no objections, I'll merge this now. |
In preparation for enabling C-style comment linting, we disable the whitespace rules for TODOs. They go beyond what GSG demands, and it is unclear how to apply them to C-style comments.
In preparation for enabling C-style comment linting, we disable the whitespace rules for TODOs. They go beyond what GSG demands, and it is unclear how to apply them to C-style comments.
In preparation for enabling C-style comment linting, we disable the whitespace rules for TODOs. They go beyond what GSG demands, and it is unclear how to apply them to C-style comments.
Related to #13762 and RobotLocomotion/styleguide#31.
This change is