Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Delete unused pypi repository rules #20578

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tools/lint/buildifier-tables.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,6 @@
"git_repository.remote": 300,
"git_repository.commit": 310,

"pypi_archive.package": 300,
"pypi_archive.version": 310,
"pypi_archive.sha256": 340,
"pypi_archive.strip_prefix": 350,
"pypi_archive.build_file": 360,

"new_local_repository.path": 300,
"new_local_repository.build_file_content": 360,

Expand Down
13 changes: 0 additions & 13 deletions tools/workspace/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,6 @@ this will be susceptible to Ubuntu vs macOS differences, so please opt-in to
the macOS build(s) in Jenkins before merging, using the instructions at
https://drake.mit.edu/jenkins.html#running-an-on-demand-build.

## Updating pypi_archive software versions

To lock in a new version, change the `version` argument of the `pypi_archive`
call, comment out the `sha256` argument, and then run `bazel build`. Bazel's
fetch step will attempt to download the new version but then complain about a
checksum mismatch. Paste the new checksum into the `sha256` argument and
remove its commenting-out. Then, `bazel build` should succeed.

Commit and pull-request the changed lines to Drake as usual. Many changes like
this will be susceptible to Ubuntu vs macOS differences, so please opt-in to
the macOS build(s) in Jenkins before merging, using the instructions at
https://drake.mit.edu/jenkins.html#running-an-on-demand-build.

## Updating pkg_config_repository software versions

Most `pkg_config_repository` calls refer to libraries provided by the host
Expand Down
10 changes: 0 additions & 10 deletions tools/workspace/mirrors.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,6 @@ DEFAULT_MIRRORS = {
# N.B. ibiblio doesn't offer https.
"http://maven.ibiblio.org/maven2/{fulljar}",
],
"pypi": [
"https://files.pythonhosted.org/packages/source/{p}/{package}/{package}-{version}.tar.gz", # noqa
"https://drake-mirror.csail.mit.edu/pypi/{package}/{package}-{version}.tar.gz", # noqa
"https://s3.amazonaws.com/drake-mirror/pypi/{package}/{package}-{version}.tar.gz", # noqa
],
"pypi_wheel": [
"https://files.pythonhosted.org/packages/{blake2_256_01}/{blake2_256_23}/{blake2_256_4p}/{package}-{version}-{tag}.whl", # noqa
"https://drake-mirror.csail.mit.edu/pypi_wheel/{package}/{package}-{version}-{tag}.tar.gz", # noqa
"https://s3.amazonaws.com/drake-mirror/pypi_wheel/{package}/{package}-{version}-{tag}.tar.gz", # noqa
],
# On 2024-01-01 upon completion of @vtk deprecation, remove this stanza.
"vtk": [
"https://drake-packages.csail.mit.edu/vtk/{archive}",
Expand Down
5 changes: 0 additions & 5 deletions tools/workspace/new_release.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,6 @@ def _check_for_upgrades(gh, args, metadata):
# For details, see drake/tools/workspace/crate_universe/README.md.
print(f"Ignoring {workspace_name} from rules_rust")
continue
elif key in ["pypi", "pypi_wheel"]:
# TODO(jwnimmer-tri) Implement for real.
print("{} version {} needs manual inspection".format(
workspace_name, data["version"]))
continue
elif workspace_name == "buildifier":
assert key == "manual"
old_commit, new_commit = _handle_buildifier(gh, data)
Expand Down
255 changes: 0 additions & 255 deletions tools/workspace/pypi.bzl

This file was deleted.

Loading