Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional arguments to Plan::Step #42

Open
pangtao22 opened this issue Oct 25, 2021 · 1 comment
Open

Support additional arguments to Plan::Step #42

pangtao22 opened this issue Oct 25, 2021 · 1 comment

Comments

@pangtao22
Copy link
Member

State, defined here, is a necessary input to the Step function of all plans. However, different types plans clearly need different fields in State. For instance, TaskSpacePlan only needs the current joint angles, whereas many plan types involving tactile sensing requires measurements from the tactile sensors. The proposed solution is to make State virtual, from which new plan types can inherit can implement their own state.

@pangtao22 pangtao22 changed the title Makcing State abstract\virtual Making State abstract\virtual Oct 25, 2021
@pangtao22
Copy link
Member Author

After discussing with Terry, it turns out that this is not a good idea. It would involve lots of changes to IiwaPlanManager, including a config-file-based function call to construct State and lcm subscriptions to the additional measurements.

The alternative is to subscribe to the additional measurements in the new Plan, and store the latest measurements in local private variables. There will be two Step functions, one that's consistent with the declaration in PlanBase, and another deterministic Step that includes the additional measurements in its list or arguments. The first Step is simply a wrapper around the second.

@pangtao22 pangtao22 changed the title Making State abstract\virtual Support additional arguments to Plan::Step Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant