Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies missing from deb packages #484

Closed
farshbafdoustar opened this issue Apr 20, 2020 · 20 comments
Closed

Dependencies missing from deb packages #484

farshbafdoustar opened this issue Apr 20, 2020 · 20 comments
Labels

Comments

@farshbafdoustar
Copy link

Expected Behavior

rosbridge_websocket running

Actual Behavior

process[rosbridge_websocket-1]: started with pid [122]
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/rosbridge_server/rosbridge_websocket", line 38, in
from twisted.python import log
ImportError: No module named twisted.python

Steps to Reproduce the Problem

  1. installing the version ros-kinetic-rosbridge-suite_0.11.5 on Ubuntu Xenial (inside kinetic-ros-base-xenial)
    ....
    Setting up ros-kinetic-rosbridge-msgs (0.11.5-1xenial-20200413-135822+0000) ...
    Setting up ros-kinetic-rosbridge-server (0.11.5-1xenial-20200413-140154+0000) ...
    Setting up ros-kinetic-rosbridge-suite (0.11.5-1xenial-20200413-140413+0000) ...
    .....

Specifications

  • ROS Version (echo $ROS_DISTRO):kinetic
  • OS Version (grep DISTRIB_CODENAME /etc/lsb-release): xenial
  • Rosbridge Version (roscat rosbridge_server package.xml | grep '<version>'): 0.11.5
  • Twisted Version (python -c 'import twisted; print twisted.version'):
    Traceback (most recent call last):
    File "", line 1, in
    ImportError: No module named twisted
@mvollrath
Copy link
Contributor

I see, the package depends for rosbridge_server are broken in 0.11.5. Probably something to do with #460. Maybe the CI needs to be updated to use the new package format. @sfalexrog

@mvollrath
Copy link
Contributor

Seems like this doesn't affect melodic, only kinetic.

@farshbafdoustar
Copy link
Author

Thanks for the reply.
I have checked with rosdep from source files "tag:0.11.5" and it seems the following packages are missing as ros-kinetic-rosbridge-suite package dependency :

  • python-twisted
  • python-twisted-bin
  • python-twisted-core
  • python-autobahn
  • python-tornado
  • python-backports.ssl-match-hostname
  • python-imaging
  • python-pil

@mvollrath mvollrath changed the title rosbridge websocket 0.11.5 error : No module named twisted.python Dependencies missing from kinetic deb packages Apr 21, 2020
@mvollrath
Copy link
Contributor

Workaround for this is installing the packages listed by @farshbafdoustar (thank you for the list)

@ghost
Copy link

ghost commented Apr 22, 2020

Also requires dependencies:

  • python-bson
  • python-bson-ext

@mvollrath mvollrath changed the title Dependencies missing from kinetic deb packages Dependencies missing from deb packages Apr 22, 2020
@mvollrath
Copy link
Contributor

As of today this is affecting melodic packages too.

@moriarty
Copy link

👍 also experienced this issue today. does the ros build farm support package format 3 for all previous releases?

Is "ROS_PYTHON_VERSION" always set? or should it be defaulting to python2

@mvollrath
Copy link
Contributor

If nobody has answers within a week or so I'm reverting the change that caused this problem and making a release for the next sync.

@moriarty
Copy link

moriarty commented Apr 24, 2020

I see here:

https://github.com/ros/ros_comm/blob/melodic-devel/clients/rospy/package.xml

It’s setup very similar, and works. @jacobperron or @wjwwood when/where must ROS_PYTHON_VERSION must be to have the dependencies in the Debs set up properly?
Are the dependencies missing because the ROS_PYTHON_VERSION not set when they ran bloom?

ROS1 only uses python2 out of the box so I would assume that is what the debians would ship with python2 for all ROS1 versions, and to use python3 you need to clone export ROS_PYTHON_VERSION, setup a ROS workspace, run rosdep install (this will get the py3 deps) and then compile everything.

@wjwwood
Copy link

wjwwood commented Apr 24, 2020

Are the dependencies missing because the ROS_PYTHON_VERSION not set when they ran bloom?

I don't think that matters, but I didn't implement that feature. ros-infrastructure/bloom#551 might have the info you guys need.

@mvollrath
Copy link
Contributor

It sounds like maybe we just need to bloom with an up-to-date bloom tool?

@msmcconnell
Copy link

@mvollrath Based on your comment ~4 days ago, this will be fixed in the next kinetic sync. Is that correct?

@mvollrath
Copy link
Contributor

I've released 0.11.6 for kinetic and melodic, they should appear in the next sync for each distribution.

Confirmed that the previous release was made with bloom 0.8.0 which did not have the patch linked by William. This version will have Python (2) dependencies.

@msmcconnell
Copy link

The newest kinetic sync occurred over this past weekend. The 0.11.6 version was included and this issue was resolved for me.

@boilerbots
Copy link

Is there a way we can get this pushed out to Melodic? This breaks things that are automated for me.

@mvollrath
Copy link
Contributor

The last melodic sync was on 4/22. I bloomed this fix on 4/29. Follow ROS Discourse for distro sync updates.

@hadiTab
Copy link

hadiTab commented Jun 16, 2020

The issue is still there after the latest sync. I'm testing on melodic with release 0.11.9-1 and it's still missing bson.

@mvollrath
Copy link
Contributor

I'm using melodic 0.11.9 on Ubuntu and it works and I see this:

$ dpkg -s ros-melodic-rosbridge-library
Package: ros-melodic-rosbridge-library
Status: install ok installed
[...]
Version: 0.11.9-1bionic.20200530.133201
Depends: python-bson, python-pil, ros-melodic-geometry-msgs, ros-melodic-message-runtime, ros-melodic-roscpp, ros-melodic-rosgraph, ros-melodic-rospy, ros-melodic-rosservice, ros-melodic-rostopic, ros-melodic-std-msgs
[...]

What should I do to reproduce?

@github-actions
Copy link

This issue has been marked as stale because it has been open for 180 days with no activity. Please remove the stale label or add a comment to keep it open.

@Akumar201
Copy link

Hello , I ma using ROS neotic on my system. Using the following commands(basically installing the pakages that is not found one by one) helped me solving my error

  1. pip install twisted
  2. pip install autobah
  3. pip install pymongo (bson didn't worked for me )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants