This repository has been archived by the owner on Dec 13, 2020. It is now read-only.
Separate lock backend from celery backend #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop support for python2.6 (who use that anyway ?)
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 91.47% 94.24% +2.77%
==========================================
Files 1 8 +7
Lines 129 226 +97
Branches 16 18 +2
==========================================
+ Hits 118 213 +95
- Misses 4 9 +5
+ Partials 7 4 -3
Continue to review full report at Codecov.
|
PS: i hate CMD and PS
|
@Robpol86 Hi, any chance for review and merge ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, locking mechanism in Flask-Celery-Helper currently uses celery result backend, that is not "optimal" (cant use rabbitmq as celery result backend+locking).
This PR fixes #19 that, it allows (actualy requires) setting custom separate lock backend in configuration option
CELERY_TASK_LOCK_BACKENDsupported lock backends are:CELERY_TASK_LOCK_BACKENDis not specified with warning message)These changes required some refactoring so flask_celery is not a single file anymore...
Tests should went OK, only appveyor sometimes fails cos Chocolatey fails to install/run rabbitmq properly for some reason...