From 71a140c1f250354b1619763a6fd2ee11b6147f79 Mon Sep 17 00:00:00 2001 From: ayush3160 Date: Thu, 6 Apr 2023 01:46:15 +0530 Subject: [PATCH 1/2] Error message modal added --- github/modals/pullDetailsModal.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/github/modals/pullDetailsModal.ts b/github/modals/pullDetailsModal.ts index 13d9154..41651db 100644 --- a/github/modals/pullDetailsModal.ts +++ b/github/modals/pullDetailsModal.ts @@ -15,6 +15,7 @@ import { UIKitInteractionContext, } from "@rocket.chat/apps-engine/definition/uikit"; import { storeInteractionRoomData, getInteractionRoomData } from "../persistance/roomInteraction"; +import { messageModal } from "./messageModal"; export async function pullDetailsModal({ data, @@ -64,6 +65,19 @@ export async function pullDetailsModal({ const pullRequestFiles = pullRequestFilesRaw.data; + if(pullData.message === 'Not Found'){ + const modal = await messageModal({ + message:`🤖 Error Fetching Pull Request Data ⚠️`, + modify: modify, + read: read, + persistence: persistence, + http: http, + uikitcontext: uikitcontext + }) + + return modal + } + block.addSectionBlock({ text: { text: `*${pullData?.title}*`, From 07d585c83a2eed96670fc4e802336b44a0a299b6 Mon Sep 17 00:00:00 2001 From: ayush3160 Date: Thu, 6 Apr 2023 14:40:48 +0530 Subject: [PATCH 2/2] minor change --- github/modals/pullDetailsModal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/github/modals/pullDetailsModal.ts b/github/modals/pullDetailsModal.ts index 41651db..0ff9eed 100644 --- a/github/modals/pullDetailsModal.ts +++ b/github/modals/pullDetailsModal.ts @@ -65,7 +65,7 @@ export async function pullDetailsModal({ const pullRequestFiles = pullRequestFilesRaw.data; - if(pullData.message === 'Not Found'){ + if(!pullRawData.statusCode.toString().startsWith("2")){ const modal = await messageModal({ message:`🤖 Error Fetching Pull Request Data ⚠️`, modify: modify,