review

RocketChat · Oct 23, 2023 · 1ec329b · 1ec329b
1 parent ed5734c
commit 1ec329b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/apps/meteor/app/cloud/server/functions/supportedVersionsToken/supportedVersionsToken.ts b/apps/meteor/app/cloud/server/functions/supportedVersionsToken/supportedVersionsToken.ts
@@ -84,10 +84,9 @@ const cacheValueInSettings = <T extends SettingValue>(
 	);
 };
 
-const releaseEndpoint =
-	process.env.OVERWRITE_INTERNAL_RELEASE_URL && process.env.OVERWRITE_INTERNAL_RELEASE_URL.trim().length > 0
-		? process.env.OVERWRITE_INTERNAL_RELEASE_URL
-		: 'https://releases.rocket.chat/v2/server/supportedVersions';
+const releaseEndpoint = process.env.OVERWRITE_INTERNAL_RELEASE_URL?.trim()
+	? process.env.OVERWRITE_INTERNAL_RELEASE_URL.trim()
+	: 'https://releases.rocket.chat/v2/server/supportedVersions';
 
 const getSupportedVersionsFromCloud = async () => {
 	if (process.env.CLOUD_SUPPORTED_VERSIONS_TOKEN) {

diff --git a/apps/meteor/app/version-check/server/functions/buildVersionUpdateMessage.ts b/apps/meteor/app/version-check/server/functions/buildVersionUpdateMessage.ts
@@ -15,10 +15,11 @@ export const buildVersionUpdateMessage = async (
 ) => {
 	const lastCheckedVersion = settings.get<string>('Update_LatestAvailableVersion');
 
+	if (!lastCheckedVersion) {
+		return;
+	}
+
 	for await (const version of versions) {
-		if (!lastCheckedVersion) {
-			break;
-		}
 		if (semver.lte(version.version, lastCheckedVersion)) {
 			continue;
 		}