test: fix flaky unread collapser

RocketChat · Nov 22, 2024 · c1160fe · c1160fe
1 parent 66b5913
commit c1160fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/apps/meteor/tests/e2e/feature-preview.spec.ts b/apps/meteor/tests/e2e/feature-preview.spec.ts
@@ -156,13 +156,9 @@ test.describe.serial('feature preview', () => {
 			const item = poHomeChannel.sidebar.getSearchRoomByName(targetChannel);
 			await poHomeChannel.sidebar.markItemAsUnread(item);
 			await poHomeChannel.sidebar.escSearch();
+			await poHomeChannel.sidebar.getCollapseGroupByName('Channels').click();
 
-			await expect(async () => {
-				const collapser = poHomeChannel.sidebar.getCollapseGroupByName('Channels');
-				await collapser.click();
-
-				await expect(poHomeChannel.sidebar.getItemUnreadBadge(collapser)).toBeVisible();
-			}).toPass();
+			await expect(poHomeChannel.sidebar.getItemUnreadBadge(poHomeChannel.sidebar.getCollapseGroupByName('Channels', false))).toBeVisible();
 		});
 	});
 

diff --git a/apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts b/apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts
@@ -82,8 +82,8 @@ export class Sidebar {
 		await this.page.getByRole('option', { name: 'Mark Unread' }).click();
 	}
 
-	getCollapseGroupByName(name: string): Locator {
-		return this.channelsList.getByRole('button', { name, exact: true });
+	getCollapseGroupByName(name: string, exact?: boolean): Locator {
+		return this.channelsList.getByRole('button', { name, exact });
 	}
 
 	getItemUnreadBadge(item: Locator): Locator {