fix: mention channel redirecting to own DM (#31099)

RocketChat · Nov 30, 2023 · d71876c · d71876c
1 parent 157f8f4
commit d71876c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/silver-mice-allow.md b/.changeset/silver-mice-allow.md
@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+fix: mention channel redirecting to own DM
diff --git a/apps/meteor/client/views/room/hooks/useOpenRoom.ts b/apps/meteor/client/views/room/hooks/useOpenRoom.ts
@@ -75,7 +75,7 @@ export function useOpenRoom({ type, reference }: { type: RoomType; reference: st
 
 			const { LegacyRoomManager } = await import('../../../../app/ui-utils/client');
 
-			if (room._id !== reference && type === 'd') {
+			if (reference !== undefined && room._id !== reference && type === 'd') {
 				// Redirect old url using username to rid
 				await LegacyRoomManager.close(type + reference);
 				directRoute.push({ rid: room._id }, (prev) => prev);