Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Message Dispatches on changing User Role #34288

Closed
thepiyush-303 opened this issue Dec 21, 2024 · 4 comments · Fixed by #34503
Closed

Wrong Message Dispatches on changing User Role #34288

thepiyush-303 opened this issue Dec 21, 2024 · 4 comments · Fixed by #34503
Labels
Tasked Added to the internal issue tracking

Comments

@thepiyush-303
Copy link
Contributor

Description:

Any Room -> User info -> change their Roles (e.g set as moderator/leader) -> wrong message dispatches

Steps to reproduce:

Expected behavior:

Actual behavior:

Server Setup Information:

  • Version of Rocket.Chat Server: 7.2.0-develop
  • License Type:
  • Number of Users: 2
  • Operating System: ubuntu
  • Deployment Method: development
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version: Firefox

Additional context

Screencast.from.2024-12-20.21-49-12.webm

Relevant logs:

In the above clip it is shown than when removing user from Moderator Role it says Added.
@thepiyush-303 thepiyush-303 mentioned this issue Dec 21, 2024
Closed
@ritikpal1122
Copy link

hi @thepiyush-303 can i work on this ?

@thepiyush-303
Copy link
Contributor Author

There is already a PR

@reetp
Copy link

reetp commented Dec 23, 2024

hi @thepiyush-303 can i work on this ?

Please read thoroughly.

@reetp reetp added the Tasked Added to the internal issue tracking label Dec 23, 2024
@casalsgh
Copy link
Contributor

will ask eng for a PR review

@dougfabris dougfabris mentioned this issue Dec 24, 2024
Merged
@kodiakhq kodiakhq bot closed this as completed in #34503 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tasked Added to the internal issue tracking
Projects
None yet
Milestone
No milestone
5 participants
@reetp @casalsgh @ritikpal1122 @thepiyush-303 and others