Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apps typing indicator not working #30360

Merged
merged 7 commits into from
Oct 16, 2023
Merged

fix: apps typing indicator not working #30360

merged 7 commits into from
Oct 16, 2023

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Sep 12, 2023 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

  • Update the notifyRoom call, to fix the typing indicator

Issue(s)

Steps to test or reproduce

  • From any app try to call the typing bridge
  • E: "App is typing..." to display on composer
  • A: No indication/activity on FE

Further comments

AECO-375

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b9c2b15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #30360 (b9c2b15) into develop (c38711b) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30360      +/-   ##
===========================================
- Coverage    51.29%   51.12%   -0.18%     
===========================================
  Files          811      805       -6     
  Lines        15059    15074      +15     
  Branches      2751     2784      +33     
===========================================
- Hits          7725     7707      -18     
- Misses        6926     6933       +7     
- Partials       408      434      +26
Flag Coverage Δ
e2e 48.43% <ø> (-0.14%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Dnouv Dnouv marked this pull request as ready for review September 12, 2023 15:56
@Dnouv Dnouv requested a review from a team as a code owner September 12, 2023 15:56
@Dnouv Dnouv added this to the 6.5.0 milestone Sep 12, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2023
@kodiakhq kodiakhq bot merged commit 809eb63 into develop Oct 16, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the fix/appsTyping branch October 16, 2023 19:50
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@Dnouv @debdutdeb
fix: apps typing indicator not working (#30360)
d6e2784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoevanp tiagoevanp tiagoevanp approved these changes

Assignees
No one assigned
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
6.5
Development

Successfully merging this pull request may close these issues.
4 participants
@Dnouv @tiagoevanp @janainaCoelhoRocketchat @casalsgh