-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix API test flakiness #30657
test: fix API test flakiness #30657
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #30657 +/- ##
===========================================
- Coverage 51.24% 51.11% -0.14%
===========================================
Files 811 809 -2
Lines 15078 15177 +99
Branches 2752 2814 +62
===========================================
+ Hits 7727 7758 +31
- Misses 6941 6978 +37
- Partials 410 441 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
00d52ed
to
7968c94
Compare
@KevLehman @sampaiodiego |
hey @blacktoby , is it really broken? I thought it was not affecting production environments |
Yes it is. The error explained in this PR 29903 is still happening in 6.4.4. All in all we are experiencing a lot of problems with the message export. One was fixed with 6.4.4 - but this one still remains. Often the mail for the file export is not sent or received. When it is not sent, we can see the error in the PR above. |
@sampaiodiego thanks for putting the pr into the 6.4.5 release. This helped us tremendously! Now the message export for rooms works as expected. |
that's good to hear @blacktoby .. thx for the heads up! otherwise the fix would have to wait for 6.5.0 |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments