Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix API test flakiness #30657

Merged
merged 6 commits into from
Oct 20, 2023
Merged

test: fix API test flakiness #30657

merged 6 commits into from
Oct 20, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: 065be50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #30657 (065be50) into develop (94c6e89) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30657      +/-   ##
===========================================
- Coverage    51.24%   51.11%   -0.14%     
===========================================
  Files          811      809       -2     
  Lines        15078    15177      +99     
  Branches      2752     2814      +62     
===========================================
+ Hits          7727     7758      +31     
- Misses        6941     6978      +37     
- Partials       410      441      +31     
Flag Coverage Δ
e2e 48.38% <ø> (-0.10%) ⬇️
unit 64.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the fix-api-test-flakyness branch from 00d52ed to 7968c94 Compare October 20, 2023 12:08
@sampaiodiego sampaiodiego marked this pull request as ready for review October 20, 2023 12:13
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 20, 2023 12:13
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 20, 2023
@kodiakhq kodiakhq bot merged commit daa28f0 into develop Oct 20, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the fix-api-test-flakyness branch October 20, 2023 17:31
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@blacktoby
Copy link

@KevLehman @sampaiodiego
When is this commit going into the next bugfix release? We are waiting for it, since it fixes the message export in rooms.

@sampaiodiego
Copy link
Member Author

hey @blacktoby , is it really broken? I thought it was not affecting production environments

@blacktoby
Copy link

blacktoby commented Oct 31, 2023

Yes it is. The error explained in this PR 29903 is still happening in 6.4.4.
You commented, that the problem is fixed with this PR. So I hoped it will soon go live.

All in all we are experiencing a lot of problems with the message export. One was fixed with 6.4.4 - but this one still remains. Often the mail for the file export is not sent or received. When it is not sent, we can see the error in the PR above.

@sampaiodiego sampaiodiego added this to the 6.4.5 milestone Nov 1, 2023
sampaiodiego added a commit that referenced this pull request Nov 1, 2023
@blacktoby
Copy link

@sampaiodiego thanks for putting the pr into the 6.4.5 release. This helped us tremendously! Now the message export for rooms works as expected.

@sampaiodiego
Copy link
Member Author

that's good to hear @blacktoby .. thx for the heads up! otherwise the fix would have to wait for 6.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants