Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(federation-v2): update registration file with new field #33281

Merged
merged 7 commits into from
Dec 11, 2024
Merged

chore(federation-v2): update registration file with new field #33281

merged 7 commits into from
Dec 11, 2024

Conversation

debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 13, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: df9e634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33281/
on branch gh-pages at 2024-12-10 14:51 UTC

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.28%. Comparing base (41f5df1) to head (df9e634).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #33281       +/-   ##
============================================
- Coverage    75.79%   60.28%   -15.51%     
============================================
  Files          511     2680     +2169     
  Lines        22132    65863    +43731     
  Branches      5394    14588     +9194     
============================================
+ Hits         16775    39708    +22933     
- Misses        4709    23362    +18653     
- Partials       648     2793     +2145
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb marked this pull request as ready for review October 15, 2024 14:50
@debdutdeb debdutdeb requested a review from a team as a code owner October 15, 2024 14:50
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 22, 2024
@MarcosSpessatto MarcosSpessatto added this to the 7.1.0 milestone Oct 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@casalsgh casalsgh modified the milestones: 7.1.0, 7.2.0 Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@ggazzo ggazzo added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Dec 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 10, 2024
@kodiakhq kodiakhq bot merged commit ac79766 into develop Dec 11, 2024
48 of 49 checks passed
@kodiakhq kodiakhq bot deleted the update-registration-file branch December 11, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@debdutdeb @MarcosSpessatto @ggazzo @casalsgh