From 0f9ba302c597612e41f8458288e62b01d5449b6c Mon Sep 17 00:00:00 2001 From: Jean Brito Date: Wed, 18 Dec 2024 15:03:41 -0300 Subject: [PATCH 1/3] fix new version banner text translation --- apps/meteor/client/views/banners/hooks/useUserBanners.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/apps/meteor/client/views/banners/hooks/useUserBanners.ts b/apps/meteor/client/views/banners/hooks/useUserBanners.ts index 8623173b348e..e11a4b6224ad 100644 --- a/apps/meteor/client/views/banners/hooks/useUserBanners.ts +++ b/apps/meteor/client/views/banners/hooks/useUserBanners.ts @@ -27,7 +27,12 @@ export const useUserBanners = () => { banners.open({ id: firstBanner.id, title: i18n.exists(firstBanner.title) ? t(firstBanner.title) : firstBanner.title, - text: i18n.exists(firstBanner.text) ? t(firstBanner.text, firstBanner.textArguments) : firstBanner.text, + text: i18n.exists(firstBanner.text) + ? t(firstBanner.text, { + postProcess: 'sprintf', + sprintf: firstBanner.textArguments, + }) + : firstBanner.text, modifiers: firstBanner.modifiers, action() { if (firstBanner.link) { From e844ec2487e6ad127e9e77af3af5ee0ea4529700 Mon Sep 17 00:00:00 2001 From: Jean Brito Date: Wed, 18 Dec 2024 15:51:42 -0300 Subject: [PATCH 2/3] Create slow-readers-help.md --- .changeset/slow-readers-help.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/slow-readers-help.md diff --git a/.changeset/slow-readers-help.md b/.changeset/slow-readers-help.md new file mode 100644 index 000000000000..429a0b1937af --- /dev/null +++ b/.changeset/slow-readers-help.md @@ -0,0 +1,5 @@ +--- +"@rocket.chat/meteor": patch +--- + +fix: Update banner not showing the new version number From f64e5679cf4dc6e11651d52dbc8d9ed0dd8cc6a9 Mon Sep 17 00:00:00 2001 From: Douglas Fabris Date: Wed, 18 Dec 2024 15:58:30 -0300 Subject: [PATCH 3/3] chore: update changeset --- .changeset/slow-readers-help.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/slow-readers-help.md b/.changeset/slow-readers-help.md index 429a0b1937af..2fe4881b56a0 100644 --- a/.changeset/slow-readers-help.md +++ b/.changeset/slow-readers-help.md @@ -2,4 +2,4 @@ "@rocket.chat/meteor": patch --- -fix: Update banner not showing the new version number +Fixes an issue where the update banner wasn't showing the new version number