Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scroll the conversation to top #31874

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: Scroll the conversation to top #31874

wants to merge 4 commits into from
+34 −0

Conversation

Subhojit-Dey1234
Copy link
Contributor

@Subhojit-Dey1234 Subhojit-Dey1234 commented Mar 2, 2024 •
edited by dougfabris
Loading

feat: Adding a new feature for the scrolling the conversation to the top.

Proposed changes (including videos or screenshots)

Screen.Recording.2024-03-02.at.12.04.08.PM.mov

Issue(s)

Closes RocketChat/feature-requests#882

Further comments

I have added an if condition with tab in the url. Please comment for any further changes.

@Subhojit-Dey1234 Subhojit-Dey1234 requested a review from a team as a code owner March 2, 2024 06:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b60ff6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Subhojit-Dey1234 Subhojit-Dey1234 changed the title ISSUE-31714 | Scroll the conversation to top feat: Scroll the conversation to top Mar 2, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.58%. Comparing base (000f601) to head (8b60ff6).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   RocketChat/Rocket.Chat#31874      +/-   ##
===========================================
+ Coverage    54.57%   54.58%   +0.01%     
===========================================
  Files         2283     2283              
  Lines        50280    50259      -21     
  Branches     10251    10250       -1     
===========================================
- Hits         27440    27435       -5     
+ Misses       20347    20339       -8     
+ Partials      2493     2485       -8
Flag Coverage Δ
e2e 53.58% <54.54%> (+0.04%) ⬆️
e2e-api 39.97% <ø> (-0.04%) ⬇️
unit 76.44% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Subhojit-Dey1234 Subhojit-Dey1234 mentioned this pull request Mar 2, 2024
Open
thesynthax
thesynthax reviewed Mar 5, 2024
View reviewed changes
apps/meteor/client/hooks/roomActions/useGetTopMessageRoomAction.ts
Copy link

@thesynthax thesynthax Mar 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change title: 'Start_of_converstation', to title: 'Go_to_first_message',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

thesynthax
thesynthax reviewed Mar 5, 2024
View reviewed changes
packages/i18n/src/locales/en.i18n.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Start_of_converstation" : "Start_of_converstation", to "Go_to_first_message" : "Go to first message",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesynthax thesynthax thesynthax left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add a "Go to first message" button in the chat
4 participants
@Subhojit-Dey1234 @thesynthax @ggazzo @sampaiodiego