Skip to content

Commit

Permalink
fix(mp3-encoder): Suppress assertion
Browse files Browse the repository at this point in the history
  • Loading branch information
tassoevan committed Nov 8, 2024
1 parent 5ac71a3 commit 9946554
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/ninety-monkeys-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/mp3-encoder': patch
---

Suppressed assertions at the LAME encoding due to unknown `NaN` values
11 changes: 7 additions & 4 deletions packages/mp3-encoder/src/lame/assert.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
export function assert(
condition: boolean,
message?: string,
_message?: string,
): asserts condition {
if (!condition) {
throw new Error(message);
}
// TODO: There is a condition generating multiple NaN values that was never
// addressed in the original code and is not clear how to handle it.
// Originally this assertion was commented out, probably because of it.
// if (!condition) {
// throw new Error(message);
// }
}

0 comments on commit 9946554

Please sign in to comment.