From 9b325a1e1a31448b480b84a1743d85daf4bc5385 Mon Sep 17 00:00:00 2001 From: Tiago Evangelista Pinto Date: Fri, 1 Sep 2023 14:20:57 -0300 Subject: [PATCH] fix(ui-kit): Remove `icons` package dependency in `ui-kit` package (#1154) --- packages/ui-kit/README.md | 10 ---------- packages/ui-kit/package.json | 4 ---- packages/ui-kit/src/blocks/layout/CalloutBlock.ts | 3 --- 3 files changed, 17 deletions(-) diff --git a/packages/ui-kit/README.md b/packages/ui-kit/README.md index ff39be68a1..cf02d0ed03 100644 --- a/packages/ui-kit/README.md +++ b/packages/ui-kit/README.md @@ -22,16 +22,6 @@ -Firstly, install the peer dependencies (prerequisites): - -```sh -npm i @rocket.chat/icons - -# or, if you are using yarn: - -yarn add @rocket.chat/icons -``` - Add `@rocket.chat/ui-kit` as a dependency: ```sh diff --git a/packages/ui-kit/package.json b/packages/ui-kit/package.json index 959eb20f86..29fb36859a 100644 --- a/packages/ui-kit/package.json +++ b/packages/ui-kit/package.json @@ -42,7 +42,6 @@ "@babel/plugin-transform-runtime": "~7.21.4", "@babel/preset-env": "~7.21.4", "@rocket.chat/eslint-config-alt": "workspace:~", - "@rocket.chat/icons": "workspace:~", "@rocket.chat/prettier-config": "workspace:~", "@types/jest": "~29.5.0", "babel-loader": "~9.1.2", @@ -60,8 +59,5 @@ "typescript": "~5.0.4", "webpack": "~5.78.0", "webpack-cli": "~5.0.1" - }, - "peerDependencies": { - "@rocket.chat/icons": "*" } } diff --git a/packages/ui-kit/src/blocks/layout/CalloutBlock.ts b/packages/ui-kit/src/blocks/layout/CalloutBlock.ts index 0b0cfe76fd..f8bb01d254 100644 --- a/packages/ui-kit/src/blocks/layout/CalloutBlock.ts +++ b/packages/ui-kit/src/blocks/layout/CalloutBlock.ts @@ -1,12 +1,9 @@ -import type { Keys } from '@rocket.chat/icons'; - import type { LayoutBlockish } from '../LayoutBlockish'; import type { TextObject } from '../TextObject'; export type CalloutBlock = LayoutBlockish<{ type: 'callout'; title?: TextObject; - icon?: Keys; text: TextObject; variant?: 'info' | 'danger' | 'warning' | 'success'; }>;