fix: dropdown-closing-issue-fixed #31437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because the proper fix should be done on the fuselage side. Questions? Help needed? Feature Requests?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the dropdown closing issue when clicked somewhere on modal.
Checklist:
[X] - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
[X] - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
[X] - Lint and unit tests pass locally with my changes
[X] - I have added tests that prove my fix is effective or that my feature works (if applicable)
[X] - I have added necessary documentation (if applicable)
[X] - Any dependent changes have been merged and published in downstream modules
Proposed changes (including videos or screenshots)
rc-drop.webm
Issue(s)
Fixes RocketChat/fuselage#1306
Steps to test or reproduce
Create Channelsection.CreateChannelModal.tsxhas been changed.Further comments
The dropdown input size is altered to incorporate the fix. But doesn't affect the overall input field functionality.