Pr commentaries resolved

RoryMCDev · Nov 14, 2021 · 7729565 · 7729565
1 parent 08cb90f
commit 7729565
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
 
     strategy:
       matrix:
-        java: [8, 9, 10, 11, 12, 13, 14, 15, 16, 17]
+        java: [8, 11, 16, 17]
 
     steps:
       - name: Checkout

diff --git a/src/main/java/fr/moribus/imageonmap/commands/IoMCommand.java b/src/main/java/fr/moribus/imageonmap/commands/IoMCommand.java
@@ -57,15 +57,12 @@ public abstract class IoMCommand extends Command {
 
 
     protected boolean checkHostingSite(URL url) {
-        PluginLogger.info("allow list " + PluginConfiguration.ALLOWLIST_HOSTINGSITE.get());
         String urlsString = PluginConfiguration.ALLOWLIST_HOSTINGSITE.get();
-        if (urlsString.trim().equals("")) {
+        if (urlsString.trim().isEmpty()) {
             return true;
         }
         String[] hosts = urlsString.trim().replaceAll("https://","").split(",");
         for (String host : hosts) {
-            PluginLogger.info(host);
-            PluginLogger.info(url.getHost());
             if (url.getHost().equals(host.trim())) {
                 return true;
             }

diff --git a/src/main/java/fr/moribus/imageonmap/commands/maptool/NewCommand.java b/src/main/java/fr/moribus/imageonmap/commands/maptool/NewCommand.java
@@ -94,15 +94,19 @@ protected void run() throws CommandException {
             int imageCount = MapManager.getPlayerMapStore(player.getUniqueId()).getImagesCount();
             if (imageLimit <= imageCount) {
                 throwInvalidArgument(
-                        I.t("Your image limit is set to {0} and you currently have {1} ", imageLimit, imageCount));
+                        I.t("Your image limit is set to {0} and you currently have {1} loaded image(s)",
+                                imageLimit,
+                                imageCount));
             }
         }
         if (!Permissions.BYPASS_MAP_LIMIT.grantedTo(player)) {
             int mapLimit = Permissions.NEW.getLimitPermission(player, Permissions.LimitType.map);
             int mapCount = MapManager.getPlayerMapStore(player.getUniqueId()).getMapCount();
             if (mapLimit <= mapCount) {
                 throwInvalidArgument(
-                        I.t("Your map limit is set to {0} and you currently have {1} ", mapLimit, mapCount));
+                        I.t("Your map limit is set to {0} and you currently have {1} loaded map(s)",
+                                mapLimit,
+                                mapCount));
             }
         }
         try {

diff --git a/src/main/java/fr/moribus/imageonmap/gui/MapDetailGui.java b/src/main/java/fr/moribus/imageonmap/gui/MapDetailGui.java
@@ -236,7 +236,7 @@ public void rename() {
             }, map.getName(), this);
 
         } catch (IllegalStateException e) {
-            PluginLogger.info("error while renaming");
+            PluginLogger.error("Error while renaming map: ", e);
         }
     }
 

diff --git a/src/main/java/fr/moribus/imageonmap/image/ImageRendererExecutor.java b/src/main/java/fr/moribus/imageonmap/image/ImageRendererExecutor.java
@@ -38,7 +38,6 @@
 
 import fr.moribus.imageonmap.Permissions;
 import fr.moribus.imageonmap.PluginConfiguration;
-import fr.moribus.imageonmap.commands.IoMCommand;
 import fr.moribus.imageonmap.map.ImageMap;
 import fr.moribus.imageonmap.map.MapManager;
 import fr.zcraft.quartzlib.components.i18n.I;

diff --git a/src/main/java/fr/moribus/imageonmap/image/MapInitEvent.java b/src/main/java/fr/moribus/imageonmap/image/MapInitEvent.java
@@ -203,7 +203,6 @@ public void onEntityDamageByBlockEvent(EntityDamageByBlockEvent event) {
     @EventHandler
     public void onHangingBreakEvent(HangingBreakEvent event) {
         Entity entity = event.getEntity();
-        PluginLogger.info("entity " + entity.toString());
         if (!(entity instanceof ItemFrame)) {
             return;
         }