Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decreasing the number of dynamically shadowed bindings #233

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Decreasing the number of dynamically shadowed bindings #233

wants to merge 19 commits into from

Conversation

JackMaguire
Copy link
Member

Nowhere near ready for review...

@JackMaguire
Copy link
Member Author

JackMaguire commented Nov 8, 2024 •
edited
Loading

@lyskov Why did -class protocols::mean_field::jagged_array< protocols::mean_field::AAProb > not work? I'm still seeing that the class got bound in the failed unit tests:

CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::assign` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::assign` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::capacity` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::clear` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::empty` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::max_size` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::pop_back` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::reserve` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'int'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>, <class 'int'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::resize` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'int'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>, <class 'int'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::size` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>]`
CONFLICT `<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>::swap` --- `[<class 'pyrosetta.rosetta.protocols.mean_field.jagged_array_protocols_mean_field_AAProb_std_allocator_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.std.vector_utility_vector1_protocols_mean_field_AAProb_t'>]` --- `[<class 'pyrosetta.rosetta.utility.vector1_utility_vector1_protocols_mean_field_AAProb_t'>, <class 'pyrosetta.rosetta.std.vector_utility_vector1_protocols_mean_field_AAProb_t'>]`

Edit: This isn't urgent. I found a workaround. I'm more just curious about why it failed than how to fix it

@JackMaguire
Copy link
Member Author

Down from 276 to 182

@lyskov
Copy link
Member

lyskov commented Nov 8, 2024

@lyskov Why did -class protocols::mean_field::jagged_array< protocols::mean_field::AAProb > not work? I'm still seeing that the class got bound in the failed unit tests:

-- one need to use full C++ class/function name with all template arguments. Easiest way to find such name is to look at generated C++ sources (see source/build/PyRosetta dir if you build locally). For this particular case full name is probably something like:

protocols::mean_field::jagged_array<protocols::mean_field::AAProb,std::allocator<protocols::mean_field::AAProb>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 PyRosetta industry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackMaguire @lyskov